Skip to content

Remove support for sharding#768

Merged
AliyanH merged 2 commits into
Maps4HTML:mainfrom
AliyanH:removeSharding
Feb 24, 2023
Merged

Remove support for sharding#768
AliyanH merged 2 commits into
Maps4HTML:mainfrom
AliyanH:removeSharding

Conversation

@AliyanH

@AliyanH AliyanH commented Feb 23, 2023

Copy link
Copy Markdown
Member

@AliyanH AliyanH requested a review from prushforth February 24, 2023 15:51
@AliyanH

AliyanH commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

@prushforth

Copy link
Copy Markdown
Member

I am not sure if this code is linked to sharding or not:

https://github.com/Maps4HTML/Web-Map-Custom-Element/blob/0e006d230b3726b8f2c40c7c749f444b1068d0b1/src/mapml/layers/TemplatedTileLayer.js#L170-L174

No. It tests to see if there are any variables in the URL template that aren't part the parameters required to obtain a tile i.e. the row/col/zoom or the tile's extent coordinates (left/right/top/bottom). If such a variable exists, it's name is made a member of the variables who's value will be generated via controls in the layer control e.g. time select or something like that.

@prushforth

Copy link
Copy Markdown
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants